Coverity Errors |
| Issues for pmlogger |
| ID |
Checker |
File |
Function |
Classification |
| 11 |
CHECKED_RETURN |
/src2/git/pcp/src/pmlogger/check.c |
undo |
FIXED |
| | Commit bc1f2d9 changes the prototypes for some of the __pmOptFetch*() routines from int to void |
| 40 |
FORWARD_NULL |
/src2/git/pcp/src/pmlogger/<stdout> |
yy_get_next_buffer |
IGNORED |
| | Context is flex generated code (from lex.l) where it appears the pointer cannot be NULL |
| 46 |
FORWARD_NULL |
/src2/git/pcp/src/pmlogger/dopdu.c |
update_metric |
FIXED |
| | No issue here, but commit bcf0c68 adds an assert() to ensure the pointer in question is not NULL |
| 96 |
NEGATIVE_RETURNS |
/src2/git/pcp/src/pmlogger/callback.c |
log_callback |
FIXED |
| | Commit 5612bbd adds an assert() for each ftell() where the result is used to compute an offset for a later call to fseek() |
| 97 |
NEGATIVE_RETURNS |
/src2/git/pcp/src/pmlogger/callback.c |
log_callback |
FIXED |
| | See commit 5612bbd |
| 114 |
NEGATIVE_RETURNS |
/src2/git/pcp/src/pmlogger/callback.c |
log_callback |
FIXED |
| | See commit 5612bbd |
| 150 |
RESOURCE_LEAK |
/src2/git/pcp/src/pmlogger/pmlogger.c |
ParseSize |
FIXED |
| | Commit 2c9ea48 |
| 158 |
RESOURCE_LEAK |
/src2/git/pcp/src/pmlogger/preamble.c |
do_preamble |
FIXED |
| | Commit fd0c0ba cleans up the freeing of memory on the errror branches |
| 162 |
RESOURCE_LEAK |
/src2/git/pcp/src/pmlogger/fetch.c |
myFetch |
FIXED |
| | No real problem here, commit 1ce5353 introduces a change to try and keep Coverity quiet |
| 219 |
RESOURCE_LEAK |
/src2/git/pcp/src/pmlogger/dopdu.c |
build_vset |
IGNORED |
| | No issue, as memory allocation and free both guarded by have_desc >= 0 && desc.indom != PM_INDOM_NULL. Coverity analysis is wrong? Needs review [reviewed by Nathan] |
| 220 |
RESOURCE_LEAK |
/src2/git/pcp/src/pmlogger/dopdu.c |
build_vset |
IGNORED |
| | No issue. Same as #219, Coverity analysis is wrong? Needs review [reviewed by Nathan] |
| 232 |
RESOURCE_LEAK |
/src2/git/pcp/src/pmlogger/preamble.c |
do_preamble |
FIXED |
| | See commit fd0c0ba |
| 322 |
USE_AFTER_FREE |
/src2/git/pcp/src/pmlogger/dopdu.c |
update_metric |
FIXED |
| | Commit 42e5c46 fixes a real bug |